gh-80675: Set f_trace_lines = True on all frames upon pdb.set_trace()#110881
gh-80675: Set f_trace_lines = True on all frames upon pdb.set_trace()#110881iritkatriel merged 4 commits intopython:mainfrom
f_trace_lines = True on all frames upon pdb.set_trace()#110881Conversation
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
|
Makes sense! Applied the review suggestion. |
|
Hi @iritkatriel , just fixed the merge conflict. Let me know if you have more feedback, thanks! |
|
Do we consider this as a bug (as it's reported by coverage.py) and backport it? The impact would be fairly minimal. |
@nedbat do you think this should be backported? |
|
This is the first I've heard of it. It wasn't reported by coverage.py. The original PR description says that coverage.py does a thing that makes pdb stop working. Backporting would be a decision for the pdb people, I don't have an opinion. |
|
Sorry my bad, it is NOT reported by coverage.py, but @nedbat did ask for moving this forward in #80675 (comment) . Like I said, this matters when being used with another tracer, and the most common candidate is coverage.py. |
If the
f_trace_lines = Falseis set on the frame (for example, by coverage.py), pdb won't work properly as line events will not trigger. We setf_trace_lines = Trueon all frames and reset it when debugger is detached.