gh-109956: Also test typing.NamedTuple with copy.replace#109957
Merged
serhiy-storchaka merged 3 commits intopython:mainfrom Oct 3, 2023
Merged
gh-109956: Also test typing.NamedTuple with copy.replace#109957serhiy-storchaka merged 3 commits intopython:mainfrom
typing.NamedTuple with copy.replace#109957serhiy-storchaka merged 3 commits intopython:mainfrom
Conversation
merwok
reviewed
Sep 29, 2023
| y: int = 0 | ||
| for Point in (PointFromCall, PointFromInheritance, PointFromClass): | ||
| with self.subTest(Point=Point): | ||
| p = Point(11, 22) |
Member
There was a problem hiding this comment.
Should we test the class?
Suggested change
| p = Point(11, 22) | |
| p = Point(11, 22) | |
| assert isinstance(copy.replace(p, x=12), Point) |
Member
There was a problem hiding this comment.
Oh I meant to test the copy, not the original p!
Member
There was a problem hiding this comment.
I did not notice this conversation (I can't see the text few lines above the line I'm looking at), but I added a test for a copy just before merging. I was puzzled as to why the test for the original was added, but decided not to drag the review out.
serhiy-storchaka
approved these changes
Sep 29, 2023
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I did not think that such tests were necessary and that this was the right place for such tests. But I won't mind if you want to add them here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've also added
PointFromInheritance, since it is a very common pattern.typing.NamedTuplewithcopy.replace#109956