gh-107396: tarfiles: set self.exception before _init_read_gz()#107485
Merged
encukou merged 4 commits intopython:mainfrom Aug 21, 2023
Merged
gh-107396: tarfiles: set self.exception before _init_read_gz()#107485encukou merged 4 commits intopython:mainfrom
encukou merged 4 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
balmeida-nokia
force-pushed
the
gh-107396-tarfiles-swap_self.exception
branch
2 times, most recently
from
b7eaea9 to
5656fe0
Compare
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
In the stack call of: _init_read_gz() ``` _read, tarfile.py:548 read, tarfile.py:526 _init_read_gz, tarfile.py:491 ``` a try;except exists that uses `self.exception`, so it needs to be set before calling _init_read_gz(). closes: python#107396
balmeida-nokia
force-pushed
the
gh-107396-tarfiles-swap_self.exception
branch
from
4de3480 to
25ac1e4
Compare
ethanfurman
approved these changes
Aug 18, 2023
ethanfurman
added
type-bug
Contributor
Author
|
@ethanfurman Want me to try making the backports once this is merged? |
encukou
reviewed
Aug 21, 2023
Member
|
Hopefully bots will be able to do the backports. |
Contributor
|
Thanks @balmeida-nokia for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 21, 2023
…ythonGH-107485) In the stack call of: _init_read_gz() ``` _read, tarfile.py:548 read, tarfile.py:526 _init_read_gz, tarfile.py:491 ``` a try;except exists that uses `self.exception`, so it needs to be set before calling _init_read_gz(). (cherry picked from commit 37135d2) Co-authored-by: balmeida-nokia <83089745+balmeida-nokia@users.noreply.github.com>
|
GH-108207 is a backport of this pull request to the 3.12 branch. |
|
GH-108208 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 21, 2023
…ythonGH-107485) In the stack call of: _init_read_gz() ``` _read, tarfile.py:548 read, tarfile.py:526 _init_read_gz, tarfile.py:491 ``` a try;except exists that uses `self.exception`, so it needs to be set before calling _init_read_gz(). (cherry picked from commit 37135d2) Co-authored-by: balmeida-nokia <83089745+balmeida-nokia@users.noreply.github.com>
Yhg1s
pushed a commit
that referenced
this pull request
Aug 21, 2023
…GH-107485) (#108207) gh-107396: tarfiles: set self.exception before _init_read_gz() (GH-107485) In the stack call of: _init_read_gz() ``` _read, tarfile.py:548 read, tarfile.py:526 _init_read_gz, tarfile.py:491 ``` a try;except exists that uses `self.exception`, so it needs to be set before calling _init_read_gz(). (cherry picked from commit 37135d2) Co-authored-by: balmeida-nokia <83089745+balmeida-nokia@users.noreply.github.com>
encukou
pushed a commit
that referenced
this pull request
Aug 21, 2023
…GH-107485) (GH-108208) gh-107396: tarfiles: set self.exception before _init_read_gz() (GH-107485) In the stack call of: _init_read_gz() ``` _read, tarfile.py:548 read, tarfile.py:526 _init_read_gz, tarfile.py:491 ``` a try;except exists that uses `self.exception`, so it needs to be set before calling _init_read_gz(). (cherry picked from commit 37135d2) Co-authored-by: balmeida-nokia <83089745+balmeida-nokia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the stack call of: _init_read_gz()
a try;except exists that uses
self.exception, so it needs to be set before calling _init_read_gz().closes: #107396
AttributeError: '_Stream' object has no attribute 'exception'while trying to open tgz file #107396