[3.12] gh-105268: Remove _PyGC_FINALIZED() macro (#105350)#107348
[3.12] gh-105268: Remove _PyGC_FINALIZED() macro (#105350)#107348vstinner wants to merge 1 commit intopython:3.12from
Conversation
|
This change fix PyTorch: #105268 (comment) |
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM, but I am not sure that removing such private and undocumented macro is worth documenting. It received more fame in death than in life.
Remove the old private, undocumented and untested _PyGC_FINALIZED() macro which was kept for backward compatibility with Python 3.8 and older. (cherry picked from commit 8ddf0dd)
vstinner
force-pushed
the
remove_pygc_finalized312
branch
from
a31167b to
149ad93
Compare
|
@Yhg1s: Is this fix eligible in Python 3.12 final? It helps building PyTorch with Python 3.12 if I get it correctly. |
|
I rebased my PR fix to fix a CI issue. Sadly, 3 weeks ago, the backport couldn't be merged because of a flaky test which failed on the Ubuntu job (unrelated to this PR). |
|
Removing a macro helps building with PyTorch? That doesn't sound like a straight-forward case. But no, I see no reason this should go into 3.12 (not even two weeks ago, let alone at this stage). |
|
Ok, in that case, I prefer to not backport this change to 3.12. I close the issue. |
4 participants
Remove the old private, undocumented and untested _PyGC_FINALIZED() macro which was kept for backward compatibility with Python 3.8 and older.
(cherry picked from commit 8ddf0dd)
📚 Documentation preview 📚: https://cpython-previews--107348.org.readthedocs.build/