gh-106905: avoid incorrect SystemError about recursion depth mismatch#106906
Merged
pablogsal merged 4 commits intopython:mainfrom Nov 13, 2023
Merged
gh-106905: avoid incorrect SystemError about recursion depth mismatch#106906pablogsal merged 4 commits intopython:mainfrom
pablogsal merged 4 commits intopython:mainfrom
Conversation
Contributor
Author
|
Note that in theory this should not be necessary as there is a I can only reproduce this issue rarely in a threaded application but let like matching the recursion depth changes is an easy way to make sure that the underlying issue can bubble up instead of hiding behind the recursion depth mismatch error. |
serhiy-storchaka
approved these changes
Nov 13, 2023
Misc/NEWS.d/next/Core and Builtins/2023-07-20-11-41-16.gh-issue-106905.AyZpuB.rst
Outdated
Show resolved
Hide resolved
…e-106905.AyZpuB.rst
serhiy-storchaka
added
needs backport to 3.11
|
Thanks @mmohrhard for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @mmohrhard and @pablogsal, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 13, 2023
…smatch (pythonGH-106906) * pythongh-106905: avoid incorrect SystemError about recursion depth mismatch * Update Misc/NEWS.d/next/Core and Builtins/2023-07-20-11-41-16.gh-issue-106905.AyZpuB.rst --------- (cherry picked from commit 1447af7) Co-authored-by: Markus Mohrhard <markusm@dug.com> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-112032 is a backport of this pull request to the 3.12 branch. |
gpshead
pushed a commit
to gpshead/cpython
that referenced
this pull request
Dec 7, 2023
…epth mismatch (python#106906) Backport of 1447af7 from python#106906. * pythongh-106905: avoid incorrect SystemError about recursion depth mismatch * Update Misc/NEWS.d/next/Core and Builtins/2023-07-20-11-41-16.gh-issue-106905.AyZpuB.rst --------- Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-112849 is a backport of this pull request to the 3.11 branch. |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…smatch (python#106906) * pythongh-106905: avoid incorrect SystemError about recursion depth mismatch * Update Misc/NEWS.d/next/Core and Builtins/2023-07-20-11-41-16.gh-issue-106905.AyZpuB.rst --------- Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…smatch (python#106906) * pythongh-106905: avoid incorrect SystemError about recursion depth mismatch * Update Misc/NEWS.d/next/Core and Builtins/2023-07-20-11-41-16.gh-issue-106905.AyZpuB.rst --------- Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if this fixes my original problem but it will at least remove one source of incorrect recursion depth mismatch errors.