X Tutup
Skip to content

gh-96844: Improve error message of list.remove#106455

Merged
corona10 merged 3 commits intopython:mainfrom
corona10:gh-96844
Jul 5, 2023
Merged

gh-96844: Improve error message of list.remove#106455
corona10 merged 3 commits intopython:mainfrom
corona10:gh-96844

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Jul 5, 2023 •
edited by github-actions bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jul 5, 2023
Closed
@corona10
Copy link
Member Author

corona10 commented Jul 5, 2023 •
edited
Loading

Concern about large input -> #96844 (comment)
: It was already used for list.index method so that it will not be a issue


>>> a = []
>>> a.index(42)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: 42 is not in list

vstinner
vstinner approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree with the rationale on error message length in the issue. Maybe we can limit the error message length, but that's out of the scope of this minor change.

@corona10 corona10 merged commit 217f47d into python:main Jul 5, 2023
@corona10 corona10 deleted the gh-96844 branch July 5, 2023 22:19
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 18, 2024
@corona10 @vstinner
pythongh-96844: Improve error message of list.remove (pythongh-106455)
ba6e656 
(cherry picked from commit 217f47d)
vstinner added a commit to vstinner/cpython that referenced this pull request Mar 18, 2024
@vstinner
Revert "pythongh-96844: Improve error message of list.remove (pythong…
41db9dd 
…h-106455)"

This reverts commit 217f47d.
vstinner added a commit to vstinner/cpython that referenced this pull request Mar 18, 2024
@vstinner
Revert "pythongh-96844: Improve error message of list.remove (pythong…
c7723ea 
…h-106455)"

This reverts commit 217f47d.
vstinner added a commit that referenced this pull request Mar 18, 2024
@vstinner
Revert "gh-96844: Improve error message of list.remove (gh-106455)" (#…
f6cdc6b 
…116956)

This reverts commit 217f47d.
vstinner added a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@vstinner
Revert "pythongh-96844: Improve error message of list.remove (pythong…
aac819c 
…h-106455)" (python#116956)

This reverts commit 217f47d.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@vstinner @adorilson
Revert "pythongh-96844: Improve error message of list.remove (pythong…
03a0206 
…h-106455)" (python#116956)

This reverts commit 217f47d.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@vstinner @diegorusso
Revert "pythongh-96844: Improve error message of list.remove (pythong…
169c939 
…h-106455)" (python#116956)

This reverts commit 217f47d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10 @vstinner @bedevere-bot
X Tutup