gh-104527: zippapp will now avoid appending an archive to itself.#106076
Merged
pfmoore merged 2 commits intopython:mainfrom Jun 26, 2023
Merged
gh-104527: zippapp will now avoid appending an archive to itself.#106076pfmoore merged 2 commits intopython:mainfrom
pfmoore merged 2 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
Member
pfmoore
approved these changes
Jun 26, 2023
Member
pfmoore
left a comment
pfmoore
left a comment
There was a problem hiding this comment.
This seems like a reasonable quality of life improvement.
Contributor
Author
|
@giampaolo or @tarekziade, should a similar thing be done for shutil, or will gh-104857 be sufficent (given the usecase is less clear) |
Member
|
It is very inefficient. |
Member
|
And this change needs a test. |
Contributor
|
I believe this has broken some things – see #130379. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While #104857 does add an error message that makes it much easier to figure out what is going wrong when calling zipfile.write, some of the stdlib uses of zipfile will run into this issue when recursively zipping a directory into an archive that is a child of said directory.
Sometimes, esp. in zipapp, the desired behavior is to place the contents of foo into foo/deploy.zip, or something like that. (case in point, I discovered #104527 from a project that was trying to do just that.) In this case, zippapp should not simply throw the error that #104857 is adding, but skip over the target archive.
(should I submit another PR doing the same thing for shutil.make_archive, or should we let that one fail with an error?)