X Tutup
Skip to content

gh-104635: Eliminate redundant STORE_FAST instructions in the compiler#105320

Merged
corona10 merged 2 commits intopython:mainfrom
corona10:gh-104635
Jun 7, 2023
Merged

gh-104635: Eliminate redundant STORE_FAST instructions in the compiler#105320
corona10 merged 2 commits intopython:mainfrom
corona10:gh-104635

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Jun 5, 2023 •
edited
Loading

Benchmarks

import pyperf

runner = pyperf.Runner()
runner.timeit(name="bench dead_store",
              stmt="""
_, _, _, a = 1, 2, 3, 4
""")

Mean +- std dev: [base] 11.7 ns +- 0.2 ns -> [opt] 11.1 ns +- 0.1 ns: 1.05x faster

import pyperf

runner = pyperf.Runner()
runner.timeit(name="bench static swaps",
              stmt="""
_ = f(True, False)
""",
setup="""
def f(x, y):
    a, a = x, y
    return a
""")


Mean +- std dev: [static_base] 27.1 ns +- 0.3 ns -> [static_opt] 26.0 ns +- 0.2 ns: 1.04x faster

@corona10 corona10 requested a review from carljm June 5, 2023 14:39
@bedevere-bot bedevere-bot mentioned this pull request Jun 5, 2023
Open
@corona10 corona10 mentioned this pull request Jun 5, 2023
Closed
@corona10
Copy link
Member Author

corona10 commented Jun 5, 2023 •
edited
Loading

@carljm cc @iritkatriel

Mark's change + dead_store elimination + apply_static_swaps makes 3-5% faster without adding super instruction.

corona10
corona10 commented Jun 5, 2023
View reviewed changes
Lib/test/test_peepholer.py
('STORE_FAST', 1, 4),
('POP_TOP', 0, 4),
('RETURN_VALUE', 5)
]
Copy link
Member Author

@corona10 corona10 Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 instructions -> 5 instructions

corona10
corona10 commented Jun 5, 2023
View reviewed changes
Lib/test/test_peepholer.py
('POP_TOP', 0, 4),
('STORE_FAST', 1, 4),
('RETURN_VALUE', 5)
]
Copy link
Member Author

@corona10 corona10 Jun 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 instructions -> 5 instructions

@corona10
Copy link
Member Author

corona10 commented Jun 7, 2023

@carljm Can you please take a look at?

carljm
carljm approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@corona10 corona10 merged commit aa5b762 into python:main Jun 7, 2023
@corona10 corona10 deleted the gh-104635 branch June 7, 2023 23:40
@corona10 corona10 mentioned this pull request Jul 9, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10 @carljm @bedevere-bot
X Tutup