X Tutup
Skip to content

gh-104536: Improve multiprocessing.process._cleanup logic#104537

Merged
gpshead merged 10 commits intopython:mainfrom
z764969689:fix-issue-104536
May 22, 2023
Merged

gh-104536: Improve multiprocessing.process._cleanup logic#104537
gpshead merged 10 commits intopython:mainfrom
z764969689:fix-issue-104536

Conversation

@z764969689
Copy link
Contributor

@z764969689 z764969689 commented May 16, 2023 •
edited by gpshead
Loading

@bedevere-bot bedevere-bot mentioned this pull request May 16, 2023
Closed
@bedevere-bot
Copy link

bedevere-bot commented May 16, 2023

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost
Copy link

ghost commented May 16, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@AlexWaygood AlexWaygood changed the title gh-104536: fix issue 104536, modify multiprocessing.process._cleanup function logic gh-104536: Improve multiprocessing.process._cleanup logic May 16, 2023
z764969689 and others added 2 commits May 19, 2023 10:40
@arhadthedev
Copy link
Member

arhadthedev commented May 19, 2023

test__xxsubinterpreters failure in Hypothesis Tests on Ubuntu is a known problem tracked in gh-104341.

gpshead
gpshead reviewed May 20, 2023
View reviewed changes
@gpshead gpshead self-assigned this May 20, 2023
@gpshead gpshead added the needs backport to 3.11 only security fixes label May 20, 2023
@gpshead gpshead enabled auto-merge (squash) May 22, 2023 03:26
@gpshead gpshead merged commit ef5d00a into python:main May 22, 2023
@miss-islington
Copy link
Contributor

miss-islington commented May 22, 2023

Thanks @z764969689 for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

miss-islington commented May 22, 2023

Sorry @z764969689 and @gpshead, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker ef5d00a59207a63c6d5ae0d5d44054847d1bf3b5 3.11

@z764969689 z764969689 deleted the fix-issue-104536 branch May 22, 2023 03:53
@AlexWaygood AlexWaygood removed the needs backport to 3.11 only security fixes label May 22, 2023
@AlexWaygood AlexWaygood added the needs backport to 3.11 only security fixes label May 22, 2023
@miss-islington
Copy link
Contributor

miss-islington commented May 22, 2023

Thanks @z764969689 for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

bedevere-bot commented May 22, 2023

GH-104737 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 22, 2023
@z764969689 @arhadthedev
@gpshead @miss-islington
pythongh-104536: Improve multiprocessing.process._cleanup logic (py…
4b9a172 
…thonGH-104537)

Fix a race condition in the internal `multiprocessing.process` cleanup
logic that could manifest as an unintended `AttributeError` when calling
`BaseProcess.close()`.

---------

(cherry picked from commit ef5d00a)

Co-authored-by: Luccccifer <lukezhang764@gmail.com>
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
ambv pushed a commit that referenced this pull request May 22, 2023
@miss-islington @z764969689
@arhadthedev @gpshead
[3.11] gh-104536: Improve multiprocessing.process._cleanup logic (G…
6f94bbf 
…H-104537) (#104737)

Fix a race condition in the internal `multiprocessing.process` cleanup
logic that could manifest as an unintended `AttributeError` when calling
`BaseProcess.close()`.

(cherry picked from commit ef5d00a)

Co-authored-by: Luccccifer <lukezhang764@gmail.com>
Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Co-authored-by: Gregory P. Smith <greg@krypto.org>
tschuelia added a commit to tschuelia/Pandora that referenced this pull request Nov 6, 2023
@tschuelia
backport fix for race condition in python multiprocessing module
756a0a6 
Fix a race condition in the internal ``multiprocessing.process`` cleanup logic that could manifest as an unintended
``AttributeError`` during ``process.start``.
Backport of '_cleanup' from Python 3.12 to older Python distributions
python/cpython#104537
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@gpshead gpshead gpshead approved these changes

Assignees

@gpshead gpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

multiprocessing.process._children is not multithread-safe, BaseProcess.close() function would cause AttributeError

6 participants

@z764969689 @bedevere-bot @arhadthedev @miss-islington @gpshead @AlexWaygood
X Tutup