X Tutup
Skip to content

gh-103357: Add logging.Formater defaults support to logging.config fileConfig and dictConfig#103359

Merged
vsajip merged 4 commits intopython:mainfrom
bharel:add-defaults-logging-config
Apr 12, 2023
Merged

gh-103357: Add logging.Formater defaults support to logging.config fileConfig and dictConfig#103359
vsajip merged 4 commits intopython:mainfrom
bharel:add-defaults-logging-config

Conversation

@bharel
Copy link
Contributor

@bharel bharel commented Apr 8, 2023 •
edited by bedevere-bot
Loading

Added the support for the defaults parameter, tests suite runs well.

@bharel bharel requested a review from vsajip as a code owner April 8, 2023 00:44
@bedevere-bot bedevere-bot mentioned this pull request Apr 8, 2023
Closed
@ghost
Copy link

ghost commented Apr 8, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@arhadthedev arhadthedev added the stdlib Standard Library Python modules in the Lib/ directory label Apr 8, 2023
@arhadthedev
Copy link
Member

arhadthedev commented Apr 8, 2023

@vsajip (as a logging module expert)

@vsajip vsajip merged commit 8f54302 into python:main Apr 12, 2023
@vsajip vsajip added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Apr 12, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Apr 12, 2023

Thanks @bharel for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Apr 12, 2023

Thanks @bharel for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Apr 12, 2023

Sorry, @bharel and @vsajip, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8f54302ab49a07e857843f1a551db5ddb536ce56 3.11

@miss-islington
Copy link
Contributor

miss-islington commented Apr 12, 2023

Sorry @bharel and @vsajip, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 8f54302ab49a07e857843f1a551db5ddb536ce56 3.10

@vsajip vsajip removed the needs backport to 3.10 only security fixes label Apr 12, 2023
@vsajip
Copy link
Member

vsajip commented Apr 12, 2023

Actually 3.10 is now security-fixes only.

@bharel bharel deleted the add-defaults-logging-config branch April 13, 2023 03:57
@bharel
Copy link
Contributor Author

bharel commented Apr 13, 2023 •
edited
Loading

@vsajip Thanks for the merge 😄
Why are we adding to 3.11? Is this technically a bug fix or a new feature? I'm guessing you took it as a bug fix, but I saw it as a feature. Keep in mind that the Python version I've set in the docs reference 3.12, and must be changed to 3.11.3/4 if so.

@vsajip
Copy link
Member

vsajip commented Apr 13, 2023 •
edited
Loading

You're right, it is a new feature - I wasn't thinking clearly. Let's leave it and not backport.

@arhadthedev arhadthedev removed the needs backport to 3.11 only security fixes label Apr 13, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Apr 18, 2023
@bharel @aisk
pythongh-103357: Add logging.Formatter defaults support to logging.co…
14f6c7c 
…nfig fileConfig and dictConfig (pythonGH-103359)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Assignees

@vsajip vsajip

Labels

stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bharel @arhadthedev @miss-islington @vsajip @bedevere-bot
X Tutup