gh-101857: Allow xattr detection on musl libc#101858
Merged
gpshead merged 3 commits intopython:mainfrom Feb 14, 2023
Merged
Conversation
Previously, we checked exclusively for __GLIBC__ (AND'd with some other conditions). Checking for __linux__ instead should be fine. This fixes using e.g. os.listxattr() on systems using musl libc. Bug: https://bugs.gentoo.org/894130
Member
|
@gpshead (as the posixmodule expert) |
gpshead
reviewed
Feb 13, 2023
Member
gpshead
left a comment
gpshead
left a comment
There was a problem hiding this comment.
Overall: Makes sense to me, and a quick search seems to suggest that Android's libc (aka Bionic) includes xattr support.
we can adjust more in the future if anything needs it.
for future reference w/o digging up this PR comment thread.
gpshead
approved these changes
Feb 14, 2023
Contributor
|
Thanks @thesamesam for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-101894 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 14, 2023
Previously, we checked exclusively for `__GLIBC__` (AND'd with some other conditions). Checking for `__linux__` instead should be fine. This fixes using e.g. `os.listxattr()` on systems using musl libc. Bug: https://bugs.gentoo.org/894130 (cherry picked from commit 8be8101) Co-authored-by: Sam James <sam@gentoo.org> Co-authored-by: Gregory P. Smith <greg@krypto.org>
Contributor
Author
|
Thanks for the rapid review & merge! |
gpshead
added a commit
that referenced
this pull request
May 21, 2023
…1894) gh-101857: Allow xattr detection on musl libc (GH-101858) Previously, we checked exclusively for `__GLIBC__` (AND'd with some other conditions). Checking for `__linux__` instead should be fine. This fixes using e.g. `os.listxattr()` on systems using musl libc. Bug: https://bugs.gentoo.org/894130 (cherry picked from commit 8be8101) Co-authored-by: Sam James <sam@gentoo.org> Co-authored-by: Gregory P. Smith <greg@krypto.org>
gentoo-bot
pushed a commit
to gentoo/cpython
that referenced
this pull request
May 21, 2024
Previously, we checked exclusively for `__GLIBC__` (AND'd with some other conditions). Checking for `__linux__` instead should be fine. This fixes using e.g. `os.listxattr()` on systems using musl libc. Bug: https://bugs.gentoo.org/894130 Co-authored-by: Gregory P. Smith <greg@krypto.org>
gentoo-bot
pushed a commit
to gentoo/cpython
that referenced
this pull request
May 21, 2024
Previously, we checked exclusively for `__GLIBC__` (AND'd with some other conditions). Checking for `__linux__` instead should be fine. This fixes using e.g. `os.listxattr()` on systems using musl libc. Bug: https://bugs.gentoo.org/894130 Co-authored-by: Gregory P. Smith <greg@krypto.org>
gentoo-bot
pushed a commit
to gentoo/cpython
that referenced
this pull request
Sep 19, 2024
Previously, we checked exclusively for `__GLIBC__` (AND'd with some other conditions). Checking for `__linux__` instead should be fine. This fixes using e.g. `os.listxattr()` on systems using musl libc. Bug: https://bugs.gentoo.org/894130 Co-authored-by: Gregory P. Smith <greg@krypto.org>
gentoo-bot
pushed a commit
to gentoo/cpython
that referenced
this pull request
Sep 19, 2024
Previously, we checked exclusively for `__GLIBC__` (AND'd with some other conditions). Checking for `__linux__` instead should be fine. This fixes using e.g. `os.listxattr()` on systems using musl libc. Bug: https://bugs.gentoo.org/894130 Co-authored-by: Gregory P. Smith <greg@krypto.org>
gentoo-bot
pushed a commit
to gentoo/cpython
that referenced
this pull request
Jul 30, 2025
Previously, we checked exclusively for `__GLIBC__` (AND'd with some other conditions). Checking for `__linux__` instead should be fine. This fixes using e.g. `os.listxattr()` on systems using musl libc. Bug: https://bugs.gentoo.org/894130 Co-authored-by: Gregory P. Smith <greg@krypto.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we checked exclusively for GLIBC (AND'd with some other conditions). Checking for linux instead should be fine.
This fixes using e.g. os.listxattr() on systems using musl libc.
Bug: https://bugs.gentoo.org/894130
posixmodule.cdoesn't detect xattr support on Linux with non-glibc (e.g. musl) #101857