Finding a test_importlib refleak on aarch64 RHEL8 #101394#101847
Finding a test_importlib refleak on aarch64 RHEL8 #101394#101847sobolevn wants to merge 1 commit intopython:mainfrom
test_importlib refleak on aarch64 RHEL8 #101394#101847Conversation
|
I am 95% certain, that this is not the case. Looks like Refleak was not run for a long period of time and it just happened to run on this PR. But, I have to start somewhere! |
|
|
|
Ah you are trying to check the refleak was caused by this PR. |
|
@corona10 yes :) |
|
@corona10 @mdickinson wow, I amused to say that the failing job has passed: https://buildbot.python.org/all/#/builders/802/builds/630 |
|
Hmm. Very interesting. Is there any way we can get access to the machine to debug directly? Or can we at least find out which test in |
|
It looks as though at least some recent runs (e.g., https://buildbot.python.org/all/#/builders/802/builds/629) that include the changes reverted in this PR do pass. Is it possible that the result is dependent on the order in which tests are run, or the ordering of files on the filesystem, or some such? |
|
@sobolevn It does not explain anything |
|
Please, please, please. When you submit a PR to revert another PR, please always put in a comment explaining why. "Refs #XXX" is not sufficient. Please spend the extra few minutes to communicate. |
|
@gvanrossum Got it! I've updated the description. |
|
@corona10 yes, seems like it is a flaky case. Here's another build for the same PR: https://buildbot.python.org/all/#/builders/802/builds/582 And it fails :( |
test_importlib refleak on aarch64 RHEL8 #101394
|
I reproduce the issue on my docker environment |
|
Closing the PR since the root PR was found |
This reverts commit 39017e0.
I am experimenting to detect the source of the leak here: #101766
This PR was the first one that has a recorded history of this failure. However, it does not look directly related.
Refs #101394
Refs #101766
intandsetsubclass__sizeof__under-reports the instance dictionary pointer #101266