Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify
JavaList.popand EnsureIndexErroron Empty ListsSummary
This patch refactors the
JavaList.popimplementation to default thekeyparameter to-1instead ofNone, removes the special-case branch, and delegates all index handling to__compute_index. As a result, callingpop()on an empty Java list now correctly raises anIndexErrorin accordance with theMutableSequencecontract.Related Issues
Changes
Test coverage:
Added comprehensive unit tests in
java_list_test.py:testPopDefault: Verifies thatpop()removes and returns the last element.testPopPositiveIndex: Covers popping at explicit positive indices (including 0).testPopNegativeIndex: Covers various negative indices (-1,-2, etc.).testPopEdgeCases: Confirms that popping from an empty list or with out-of-bounds indices raisesIndexError.Testing
All existing tests pass, and the new
testPop*methods validate correct behavior across default, positive, negative, and edge-case scenarios.Future Considerations
JavaList.popentirely and inheritMutableSequence.pop, which appears to handle all cases correctly. That approach may reduce maintenance overhead, but risks altering backward-compatibility with any custom behavior injava_remove.