Closed
Conversation
paf31
reviewed
Apr 2, 2017
src/Node/Buffer.purs
Outdated
|
|
||
| import Prelude | ||
| import Control.Monad.Eff (Eff) | ||
| import Prim (kind Type) |
Contributor
There was a problem hiding this comment.
You don't need to import this.
Author
|
Hmm, the build seems to fails on unrecognised arguments: |
paf31
reviewed
Apr 2, 2017
package.json
Outdated
| @@ -5,9 +5,9 @@ | |||
| "build": "pulp build --censor-lib --strict" | |||
Contributor
There was a problem hiding this comment.
You need to separate arguments with -- now:
pulp build -- --censor-lib --strict
Author
There was a problem hiding this comment.
Hum.., tried this before but it didn't work, pushed anyway but build is still failing.
I'm having problems building this locally, seems to be related to pulp (FWIW, I don't like this build tool, using my own Makefiles for my projects).
|
|
Contributor
|
Thanks, but closing in favor of #19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, FWIW I made some trivial changes to get this to build again with 0.11
*toTypeand!toEffect.