This repository was archived by the owner on Dec 5, 2018. It is now read-only.
push & popStyle: Adding ellipseMode, imageMode and shapeMode#255
Open
atgeflu wants to merge 8 commits intoprocessing-js:masterfrom
Open
push & popStyle: Adding ellipseMode, imageMode and shapeMode#255atgeflu wants to merge 8 commits intoprocessing-js:masterfrom
atgeflu wants to merge 8 commits intoprocessing-js:masterfrom
Conversation
…e and imageMode work when used with pushStyle/popStyle
…de) to tests file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #234. Apart from
ellipseModeandimageModeI've also addedshapeModesince this was also missing.I've compared for what styles
pushStyle/popStyleshould work according to the original Processing source code and as far as I can tell all missing 2D ones are taken care with this PR.I've added one ref test per added mode. They fail without the fix but come correct with the fix (though some might be marked as fail because pixels are off).