feat: added the logic for generating reference docs from local custom build of p5.sound.js#1223
Open
kunstewi wants to merge 2 commits intoprocessing:2.0from
Open
feat: added the logic for generating reference docs from local custom build of p5.sound.js#1223kunstewi wants to merge 2 commits intoprocessing:2.0from
kunstewi wants to merge 2 commits intoprocessing:2.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1224
while working on p5.sound.js codebase I saw no option to test the generated docs locally from a local build of p5.sound.js although dummy console.log was present but no logic.
p5.js-website/src/scripts/parsers/reference.ts
Lines 55 to 57 in 580ec4f
the logic is present for p5.js builds, we can test local builds of p5.js.
p5.js-website/src/scripts/parsers/reference.ts
Lines 43 to 49 in 580ec4f
so i implemented the p5.sound.js local build testing the same way it's for p5.js by specifying the p5.sound.js local build path at LOCAL_P5_SOUND_PATH variable in .env file.
@ksen0 please take a look whenever you have time.
Thanks a lot for your time.