fix: add email validation for google oauth#3966
Open
Nixxx19 wants to merge 3 commits intoprocessing:developfrom
Open
fix: add email validation for google oauth#3966Nixxx19 wants to merge 3 commits intoprocessing:developfrom
Nixxx19 wants to merge 3 commits intoprocessing:developfrom
Conversation
clairep94
requested changes
Mar 7, 2026
Collaborator
clairep94
left a comment
There was a problem hiding this comment.
looks great otherwise thanks!
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Google OAuth strategy where accessing profile._json.emails[0].value without validating the emails array caused a TypeError crash when Google OAuth profiles didn't include email addresses. The fix introduces a getGooglePrimaryEmail() helper that safely extracts the primary email with proper validation, and uses it throughout the strategy callback.
Changes:
- Added
getGooglePrimaryEmail()helper function that validates the emails array and safely extracts the first email value - Added early validation at the start of the Google OAuth callback that returns a user-friendly error when no email is available
- Replaced all 6 unsafe
profile._json.emails[0].valuedirect accesses with the validatedprimaryEmailvariable
clairep94
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #3907
The Google OAuth strategy was accessing
profile._json.emails[0].valuewithout validating that theemailsarray exists or has any elements. This caused aTypeError: Cannot read property '0' of undefinedcrash when Google OAuth profiles didn't include email addresses, breaking the authentication flow.Changes:
Added email validation helper function:
getGooglePrimaryEmail()helper function that safely extracts the primary email from Google OAuth profileemailsarray exists, is an array, and has at least one elementnullfor missing or invalid emailsUpdated Google OAuth strategy callback:
profile._json.emails[0].valueaccesses with the validatedprimaryEmailvariableFiles changed:
server/config/passport.js: Added email validation helper and updated Google strategyI have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #3907