added test on up vector tilt

Forchapeatl · web-flow · commit 9d2ba5714548 · 2025-03-13T10:38:59.000+01:00
diff --git a/test/unit/webgl/p5.Camera.js b/test/unit/webgl/p5.Camera.js
@@ -277,6 +277,61 @@ suite('p5.Camera', function() {
       assert.strictEqual(myCam.upY, orig.uy, 'up Y pos changed');
       assert.strictEqual(myCam.upZ, orig.uz, 'up Z pos changed');
     });
+
+    suite('Camera Tilt and Up Vector', function() {
+      test('Tilt() correctly updates the up vector', function() {
+        var orig = getVals(myCam); // Store original camera values
+
+        // Apply tilt to the camera
+        myCam.tilt(30); // Tilt by 30 degrees
+
+        // Compute expected up vector (normalized)
+        let forward = myp5.createVector(
+          myCam.centerX - myCam.eyeX,
+          myCam.centerY - myCam.eyeY,
+          myCam.centerZ - myCam.eyeZ
+        );
+        let up = myp5.createVector(orig.ux, orig.uy, orig.uz);
+        let right = p5.Vector.cross(forward, up);
+        let expectedUp = p5.Vector.cross(right, forward).normalize();
+
+        // Verify that the up vector has changed
+        assert.notStrictEqual(myCam.upX, orig.ux, 'upX should be updated');
+        assert.notStrictEqual(myCam.upY, orig.uy, 'upY should be updated');
+        assert.notStrictEqual(myCam.upZ, orig.uz, 'upZ should be updated');
+
+        // Verify up vector matches expected values within a small margin of error
+        assert.closeTo(myCam.upX, expectedUp.x, 0.001, 'upX mismatch');
+        assert.closeTo(myCam.upY, expectedUp.y, 0.001, 'upY mismatch');
+        assert.closeTo(myCam.upZ, expectedUp.z, 0.001, 'upZ mismatch');
+      });
+
+      test('Tilt() with negative angle correctly updates the up vector', function() {
+        var orig = getVals(myCam); // Store original camera values
+
+        myCam.tilt(-30); // Tilt by -30 degrees
+
+        // Compute expected up vector (normalized)
+        let forward = myp5.createVector(
+          myCam.centerX - myCam.eyeX,
+          myCam.centerY - myCam.eyeY,
+          myCam.centerZ - myCam.eyeZ
+        );
+        let up = myp5.createVector(orig.ux, orig.uy, orig.uz);
+        let right = p5.Vector.cross(forward, up);
+        let expectedUp = p5.Vector.cross(right, forward).normalize();
+
+        // Verify that the up vector has changed
+        assert.notStrictEqual(myCam.upX, orig.ux, 'upX should be updated');
+        assert.notStrictEqual(myCam.upY, orig.uy, 'upY should be updated');
+        assert.notStrictEqual(myCam.upZ, orig.uz, 'upZ should be updated');
+
+        // Verify up vector matches expected values within a small margin of error
+        assert.closeTo(myCam.upX, expectedUp.x, 0.001, 'upX mismatch');
+        assert.closeTo(myCam.upY, expectedUp.y, 0.001, 'upY mismatch');
+        assert.closeTo(myCam.upZ, expectedUp.z, 0.001, 'upZ mismatch');
+      });
+    }); 
   });
 
   suite('Rotation with angleMode(DEGREES)', function() {
