Add example with vertical bars in BarSeriesExamples.cs#2116
Add example with vertical bars in BarSeriesExamples.cs#2116VisualMelon merged 3 commits intooxyplot:developfrom
Conversation
In the past, there was ColumnSeries, which could have the categories be placed on the X axis. The BarSeries needs them on the Y axis. The new example show how to do this, but use keys to have to categories on bottom axis in the plot anyway. Update CONTRIBUTORS Update CHANGELOG.md
| Rustam Sayfutdinov | ||
| Konstantin Stukov <havendv@gmail.com> | ||
| jorgectf No newline at end of file | ||
| jorgectf |
There was a problem hiding this comment.
sorry about this, I don't know how this got in here
There was a problem hiding this comment.
Your editor probably put a new line at the end on saving: it's not a problem.
|
See also #1870 where I found the info which lead me to experiment and finally found out that vertical bars were indeed: possible! |
CHANGELOG.md
Outdated
| # Change Log | ||
| All notable changes to this project will be documented in this file. | ||
|
|
||
| ## [2.2.1] - 2024-12-11 |
There was a problem hiding this comment.
Should be Unreleased (my problem)
|
This is a very good idea: it is indeed a question that is asked a lot. Probably better to have a 'full' example for this, which doesn't require looking into other methods and updating the axes later. Something close to #1946 (comment) perhaps |
|
Excellent, shall I update the PR to implement a full example? I did not find the discussion you referenced, that would have been helpful :-) But, I only searched via google and in the issues, and not in the discussions. |
|
Go for it: I should have time to review it properly this weekend (feel free to ping me if I don't reply) |
|
I now added this full example. Is it possible to merge this as is? Or do I need to do some kind of rebase, cause it has been while since I opened this PR (sorry...) ? The example is now based on the first bar series example, where I removed labels and added verticality; quite a clear case. |
|
Looks fine to merge to me: I'll check it properly later today and try get it merged sooner rather than later. As always, feel free to ping me if I don't get around to it. Rules on rebasing are mostly to make sure whoever submits the PR is on a sensibly recent commit so that it doesn't produce a nightmarish merge request: no conflicts here and it's all new and self-contained code so nothing really to go wrong, |
|
@VisualMelon Have had a chance to review this? I'm happy to adjust as needed. Afterwards, I can then create a PR to allow manually loading fonts in a WASM context. Thank you! |
|
Yep, looks good to me. If it's no effort, could you change the release notes heading to "Unreleased" (rather than "[2.2.1] - 2024-12-11")? (I should have done that ages ago) |
|
Ok, I now changed the most recent version name in the changelog. |
In the past, there was ColumnSeries, which could have the categories be placed on the X axis. The BarSeries explicitly needs them on the Y axis. The new example show how use
XAxisKeyandYAxisKeyto have categories on bottom axis in the plot. There is no documentation for this, so it would be good example to have out there.Checklist
Changes proposed in this pull request:
BarSeries, showing how to make it plot vertical bars@oxyplot/admins