X Tutup
Skip to content

Fix rendering in ElementHost with SkiaSharp#1820

Merged
VisualMelon merged 5 commits intooxyplot:developfrom
AELIENUS:develop
Jan 13, 2022
Merged

Fix rendering in ElementHost with SkiaSharp#1820
VisualMelon merged 5 commits intooxyplot:developfrom
AELIENUS:develop

Conversation

@AELIENUS
Copy link
Contributor

@AELIENUS AELIENUS commented Nov 8, 2021

Fixes #1800 .

Checklist

  • I have included examples or tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file
  • I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

@oxyplot/admins

@AELIENUS
Copy link
Contributor Author

AELIENUS commented Nov 8, 2021

I could not get it to run with the "normal" WPF-Package. I needed SkiaSharp to get it to run in the ElementHost

@AELIENUS AELIENUS marked this pull request as ready for review November 8, 2021 12:50
@VisualMelon
Copy link
Contributor

Thanks for putting this together. I'll try to take a proper look at it in the next few days.

@VisualMelon
Copy link
Contributor

Overlap with #1799

@AELIENUS AELIENUS closed this Dec 23, 2021
@AELIENUS AELIENUS reopened this Dec 23, 2021
@AELIENUS
Copy link
Contributor Author

#1799 looks good to me in combination with this change. I don't think, that anything is missing, but I also don't know all UseCases. I guess time will tell.

@VisualMelon
Copy link
Contributor

VisualMelon commented Dec 23, 2021

@AELIENUS thanks for looking at #1799

I've gone through and checked most of the open PRs; I'll give the other maintainers a bit of time to look, but assuming there are no objections I will (hopefully) start merging them in a few days.

@AELIENUS
Copy link
Contributor Author

I have overlooked this again after #1799 was already merged. There were two files with conflicts: the changelog (that was rather easy to fix and i really dont understand why git flagged this as conflict in the first place) and in OxySKElement (there were inconsistencies with the documentation of GetAncestorVisualFromVisualTree there that i fixed in my branch).

@AELIENUS
Copy link
Contributor Author

@VisualMelon Can we merge this PR now or do you need more time or assistance?

@VisualMelon VisualMelon merged commit 196bb74 into oxyplot:develop Jan 13, 2022
@VisualMelon
Copy link
Contributor

Was giving other maintainers a chance to look at it, merged now.

rwasef1830 added a commit to rwasef1830/MonBand that referenced this pull request Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PlotView in ElementHost does not work.

2 participants

X Tutup