Optimize clipping calls #1661#1662
Conversation
VisualMelon
left a comment
There was a problem hiding this comment.
Basically looks good to me. I'm glad that everything still has control over it's clipping rectangle, even if it doesn't set it.
|
So this went a bit further than planned, but I do think the design makes more sense now. Basically I realized that it can be problematic that the |
|
Should we disable/comment out the |
|
@Jonarw feel free to disable them for the moment, but I take it there is no reason your changes make it unviable? I'll try to get some stuff done tomorrow (e.g. review this, tidy up the margin PR, fix maps): I'm a bit busy today. |
VisualMelon
left a comment
There was a problem hiding this comment.
Looks great now! Everything is so much tidier.
Source/Examples/ExampleLibrary/Examples/RenderingCapabilities.cs
Outdated
Show resolved
Hide resolved
3c5fb7e to
171e3d3
Compare
|
(rebased) |
Fixes #1661.
Checklist
Changes proposed in this pull request:
Rendermethods ofSeriesandAnnotationsDrawClippedXxx()extensionsRemarks
PathAnnotation.ClipTextproperty for obvious reasons was broken by these changes. As it didn't quite seem to fit the overall design anyway and appears not to be very widely used, I decided to remove it. The only place that actually used this property was the Train Schedule example. As I quite liked this example I fixed it using anAxisfor the station labels, which seems more sensible to me anyway.CandleStickAndVolumeSeriescould only be fixed by a rather ugly hack. If anything, this indicates to me that this series violates some of the design principles the library is built around, so I applied the hack and marked it as obsolete with the recommendation to use separateCandleStickSeriesandVolumeSeriesinstead.Annotations could return different clipping rectangles depending on whether you useAnnotation.GetClippingRect()or theITransposablePlotElement.GetClippingRect()extension. As this is not an ideal situation, I slightly changed the design here to make it more consistent.@oxyplot/admins