X Tutup
Skip to content

Use pre-signed URLs to download files #3797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kulmann merged 10 commits into from
Jul 28, 2020
Merged

Use pre-signed URLs to download files #3797

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5e09bf7
Use pre-signed URL to download files
LukasHirt Jul 20, 2020
03b42ee
Use pre-signed URLs to download file versions
LukasHirt Jul 20, 2020
d119b92
Fetch HEAD before download to check for 404
LukasHirt Jul 21, 2020
fe060d3
Use anchor element to trigger download
LukasHirt Jul 21, 2020
e249bd3
Fix HEAD request
kulmann Jul 23, 2020
e94c2bf
Take capability for url signing into account on downloads
kulmann Jul 23, 2020
d2d08c4
Add changelog item
kulmann Jul 23, 2020
58c7e77
Code cleanup
kulmann Jul 24, 2020
7ad405d
Fix file version download
kulmann Jul 24, 2020
e2811c3
Run CI without debug enabled
kulmann Jul 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use anchor element to trigger download
  • Loading branch information
@LukasHirt @kulmann
LukasHirt authored and kulmann committed Jul 27, 2020
commit fe060d39cc1f8cd9e617085ddaf605cc216fd7e4
16 changes: 15 additions & 1 deletion src/plugins/phoenix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,21 @@ export default {
headers: { Authorization: 'Bearer ' + this.getToken }
}).then(res => {
if (res.status === 200) {
window.location = signedUrl
const a = document.createElement('a')
a.style.display = 'none'
document.body.appendChild(a)

a.href = signedUrl

console.log(file)
// Use download attribute to set desired file name
a.setAttribute('download', file.name)

// Trigger the download by simulating click
a.click()

// Cleanup
document.body.removeChild(a)
} else if (res.status === 404) {
this.showMessage({
title: this.$gettext('Download failed'),
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2917,9 +2917,9 @@ data-uri-to-buffer@1:
resolved "https://registry.yarnpkg.com/data-uri-to-buffer/-/data-uri-to-buffer-1.2.0.tgz#77163ea9c20d8641b4707e8f18abdf9a78f34835"
integrity sha512-vKQ9DTQPN1FLYiiEEOQ6IBGFqvjCa5rSK3cWMy/Nespm5d/x3dGFT9UBZnkLxCwua/IXBi2TYnwTEpsOvhC4UQ==

"davclient.js@git+https://github.com/owncloud/davclient.js.git":
"davclient.js@https://github.com/owncloud/davclient.js.git":
version "0.2.1"
resolved "git+https://github.com/owncloud/davclient.js.git#bf19f590451b3c0658913568053ec7f300f7dfc1"
resolved "https://github.com/owncloud/davclient.js.git#bf19f590451b3c0658913568053ec7f300f7dfc1"

de-indent@^1.0.2:
version "1.0.2"
Expand Down
X Tutup