X Tutup
Skip to content

Add warning for disabling email login regarding strict login check#581

Merged
karakayasemi merged 1 commit intomasterfrom
feature/strict-login-check
Aug 1, 2020
Merged

Add warning for disabling email login regarding strict login check#581
karakayasemi merged 1 commit intomasterfrom
feature/strict-login-check

Conversation

@mrow4a
Copy link
Contributor

@mrow4a mrow4a commented Jun 22, 2020

Adds a warning that this config is not effective if strict checking is not enabled. Requires owncloud/core#37569

image

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #581 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #581   +/-   ##
=========================================
  Coverage     34.79%   34.79%           
  Complexity     1308     1308           
=========================================
  Files            31       31           
  Lines          3719     3719           
=========================================
  Hits           1294     1294           
  Misses         2425     2425           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950d322...918f74d. Read the comment docs.

@mmattel
Copy link
Contributor

mmattel commented Jul 14, 2020

@pako81 @karakayasemi @HanaGemela please rebase and merge.
Referenced core PR owncloud/core#37569 is already merged.

@HanaGemela can this be part/added to the new upcaoming release?

@karakayasemi karakayasemi force-pushed the feature/strict-login-check branch from ae87138 to ffa1ff4 Compare July 14, 2020 19:07
@karakayasemi karakayasemi force-pushed the feature/strict-login-check branch from ffa1ff4 to 959e819 Compare July 30, 2020 13:28
@karakayasemi
Copy link
Contributor

karakayasemi commented Jul 31, 2020

@phil-davis @mrow4a @micbar I just rebased the PR and CI failed. Also, there are several CI fails in nightly jobs. Looks like, one of the recent changes in core or this app, broke tests. Do you have any idea for the reason?

@phil-davis
Copy link
Contributor

phil-davis commented Jul 31, 2020

@phil-davis @mrow4a @micbar I just rebased the PR and CI failed. Also, there are several CI fails in nightly jobs. Looks like, one of the recent changes in core or this app, broke tests. Do you have any idea for the reason?

You are correct - it got broken with some core acceptance test code changes related to trying to cope with various combinations of LDAP stuff for OCIS testing. When running here in user_ldap it looks like the step:

And user "Alice" has been created with default attributes in the database user backend

now actually ends up creating Alice in LDAP. And then the display name cannot be changed "locally" in oC10.

The problem was not noticed because there is also some problem with pulling osixia/openldap and a lot of CI was failing in the setup steps, even before starting to run any tests. See #590

I will sort out the problem in core...

Update: issue #591 - core PR owncloud/core#37759 has been merged. I an running CI again now to see the result.

@karakayasemi karakayasemi force-pushed the feature/strict-login-check branch from 959e819 to 918f74d Compare August 1, 2020 12:57
@karakayasemi karakayasemi merged commit 1d8eb0b into master Aug 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/strict-login-check branch August 1, 2020 15:26
@jnweiger jnweiger mentioned this pull request Jun 14, 2021
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup