Add warning for disabling email login regarding strict login check#581
Add warning for disabling email login regarding strict login check#581karakayasemi merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
=========================================
Coverage 34.79% 34.79%
Complexity 1308 1308
=========================================
Files 31 31
Lines 3719 3719
=========================================
Hits 1294 1294
Misses 2425 2425 Continue to review full report at Codecov.
|
|
@pako81 @karakayasemi @HanaGemela please rebase and merge. @HanaGemela can this be part/added to the new upcaoming release? |
ae87138 to
ffa1ff4
Compare
ffa1ff4 to
959e819
Compare
|
@phil-davis @mrow4a @micbar I just rebased the PR and CI failed. Also, there are several CI fails in nightly jobs. Looks like, one of the recent changes in core or this app, broke tests. Do you have any idea for the reason? |
You are correct - it got broken with some core acceptance test code changes related to trying to cope with various combinations of LDAP stuff for OCIS testing. When running here in now actually ends up creating The problem was not noticed because there is also some problem with pulling I will sort out the problem in core... Update: issue #591 - core PR owncloud/core#37759 has been merged. I an running CI again now to see the result. |
959e819 to
918f74d
Compare
Adds a warning that this config is not effective if strict checking is not enabled. Requires owncloud/core#37569