X Tutup
Skip to content

fix: use firebase/php-jwt from core#401

Merged
phil-davis merged 2 commits intomasterfrom
fix/jwt-dependency
Aug 8, 2023
Merged

fix: use firebase/php-jwt from core#401
phil-davis merged 2 commits intomasterfrom
fix/jwt-dependency

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Aug 3, 2023

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs PR #400 merged-back first, then rebase this.

@SwikritiT SwikritiT mentioned this pull request Aug 4, 2023
@phil-davis
Copy link
Contributor

@DeepDiver1975 PR #400 has been merged. This can be rebased, conflicts resolved etc.

@DeepDiver1975
Copy link
Member Author

@DeepDiver1975 PR #400 has been merged. This can be rebased, conflicts resolved etc.

I am OOTO the next weeks - please take over - THX

@phil-davis phil-davis self-assigned this Aug 8, 2023
@phil-davis
Copy link
Contributor

I adjusted the acceptance tests so that they are only run against core master, which is 10.13.
We know that this does not work with core 10.12

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@phil-davis phil-davis merged commit 6d7e9c2 into master Aug 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/jwt-dependency branch August 8, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup