X Tutup
Skip to content

Enhance context menu#331

Merged
phil-davis merged 1 commit intomasterfrom
issues/330
Dec 12, 2020
Merged

Enhance context menu#331
phil-davis merged 1 commit intomasterfrom
issues/330

Conversation

@AlexAndBear
Copy link

This fix will show up a more detailed display name in the files actions menu.

required for PR owncloud/core#38132

@AlexAndBear AlexAndBear requested a review from mrow4a December 11, 2020 09:47
@CLAassistant
Copy link

CLAassistant commented Dec 11, 2020

CLA assistant check
All committers have signed the CLA.

@AlexAndBear AlexAndBear self-assigned this Dec 11, 2020
@phil-davis phil-davis changed the title Enhanche context menu Enhance context menu Dec 11, 2020
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this makes it consistent with the similar text in files_pdfviewer and richdocuments

@phil-davis
Copy link
Contributor

Note: this is "a good thing" anyway and can merged straight away. It does not break anything when used with older ownCloud 10.* core versions. So files_texteditor can be released "whenever" - no need to specially sync with the next core release.

@phil-davis
Copy link
Contributor

Note: files_texteditor is probably the best place to add tests for owncloud/core#38132 "Context menu for files in case multiple (default-)actions apply" We need a way to have a file type in CI that can be opened with multiple apps.

  • we already have UI acceptance tests here that open text files in the text editor, and can check that the editor opened, can "see" the content in the file etc. (we do not have that already in files_pdfviewer)
  • in CI we can install richdocuments app in the pipeline where we want the new tests to run
  • that will make multiple options available for opening a text file - "Open in Collabora" and "Open in Text Editor"
  • the test can easily check that these options exist
  • the test can easily click on "Open in Text Editor" and verify that the text editor opens

We do not currently have test code that can check that a PDF file has actually opened and is visible. So the combination of files_pdfviewer and richdocuments will not happen for testing.
We do not currently have test code that can check that Collabora has actually opened and the document is visible (that would require setting up all of Collabora... in CI) So clicking "Open in Collabora" will not work in CI.

So making use of files_texteditor provides a simple way to test.

We could also put the test scenarios in core, but then core would have knowledge of specific strings like "Open in Text Editor", and so the core test would break if someone changes such strings. IMO better to have the string and the test that uses it in the same repo.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup