Conversation
a682ab1 to
9d3b1b9
Compare
phil-davis
left a comment
There was a problem hiding this comment.
LGTM - this makes it consistent with the similar text in files_pdfviewer and richdocuments
|
Note: this is "a good thing" anyway and can merged straight away. It does not break anything when used with older ownCloud 10.* core versions. So |
|
Note: files_texteditor is probably the best place to add tests for owncloud/core#38132 "Context menu for files in case multiple (default-)actions apply" We need a way to have a file type in CI that can be opened with multiple apps.
We do not currently have test code that can check that a PDF file has actually opened and is visible. So the combination of files_pdfviewer and richdocuments will not happen for testing. So making use of files_texteditor provides a simple way to test. We could also put the test scenarios in core, but then core would have knowledge of specific strings like "Open in Text Editor", and so the core test would break if someone changes such strings. IMO better to have the string and the test that uses it in the same repo. |
|
Kudos, SonarCloud Quality Gate passed! |
This fix will show up a more detailed display name in the files actions menu.
required for PR owncloud/core#38132