X Tutup
Skip to content

Fix user-keys encryption when user created with email#55

Merged
phil-davis merged 1 commit intomasterfrom
fix-setuserpassword-beforelogin
Sep 12, 2018
Merged

Fix user-keys encryption when user created with email#55
phil-davis merged 1 commit intomasterfrom
fix-setuserpassword-beforelogin

Conversation

@sharidas
Copy link
Contributor

When user tries to set the password without logging
in for once and no session available, the user-keys
encryption was failing to create the private key
for the new password. This change helps to fix the
issue.

Signed-off-by: Sujith H sharidasan@owncloud.com

When user tries to set the password without logging
in for once and no session available, the user-keys
encryption was failing to create the private key
for the new password. This change helps to fix the
issue.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas sharidas self-assigned this Sep 12, 2018
@sharidas sharidas added this to the QA milestone Sep 12, 2018
@sharidas sharidas requested a review from PVince81 September 12, 2018 13:35
@sharidas
Copy link
Contributor Author

Fixes #54

@sharidas
Copy link
Contributor Author

Backport to stable10 : #55

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, as discussed 👍

@codecov-io
Copy link

Codecov Report

Merging #55 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #55      +/-   ##
============================================
+ Coverage     62.52%   62.58%   +0.05%     
- Complexity      567      568       +1     
============================================
  Files            30       30              
  Lines          2127     2130       +3     
============================================
+ Hits           1330     1333       +3     
  Misses          797      797
Impacted Files Coverage Δ Complexity Δ
lib/Hooks/UserHooks.php 73.95% <100%> (+0.84%) 36 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1493e5...62e4892. Read the comment docs.

@phil-davis phil-davis merged commit b5163b9 into master Sep 12, 2018
@phil-davis phil-davis deleted the fix-setuserpassword-beforelogin branch September 12, 2018 15:30
@phil-davis
Copy link
Contributor

Good work getting all that CI to pass.

@patrickjahns patrickjahns removed this from the QA milestone Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup