Add re-login information after successful action#21
Merged
Conversation
PVince81
reviewed
Dec 1, 2017
sharidas
force-pushed
the
relogin-info-recreate-masterkey
branch
from
7fbe5b8 to
aa42143
Compare
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
============================================
+ Coverage 64.26% 64.28% +0.01%
Complexity 598 598
============================================
Files 33 33
Lines 2211 2212 +1
============================================
+ Hits 1421 1422 +1
Misses 790 790
Continue to review full report at Codecov.
|
PVince81
reviewed
May 28, 2018
PVince81
suggested changes
May 28, 2018
Contributor
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
see comment, let's do it properly and get rid of both globals
sharidas
force-pushed
the
relogin-info-recreate-masterkey
branch
from
aa42143 to
9c16d33
Compare
Contributor
Author
|
The imho CI failure doesn't look related to this change... |
After successful re-creation of masterkey, its always better to let user know that one needs to re-login. Signed-off-by: Sujith H <sharidasan@owncloud.com>
sharidas
force-pushed
the
relogin-info-recreate-masterkey
branch
from
a0fe6b5 to
326a738
Compare
Contributor
|
@sharidas please backport |
Contributor
Author
|
Backport to stable10 : owncloud/core#34596 |
11 tasks
11 tasks
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the command is executed successfully by
recreating masterkey, the user should be informed
to relogin.
Signed-off-by: Sujith H sharidasan@owncloud.com