Codecov Report

Merging #166 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #166      +/-   ##
============================================
- Coverage     71.94%   71.77%   -0.18%     
  Complexity      612      612              
============================================
  Files            35       35              
  Lines          2299     2299              
============================================
- Hits           1654     1650       -4     
- Misses          645      649       +4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf260a7...f8afcf7. Read the comment docs.

Rebased this just now. CI is running again against the rebased core branch. Let's see the result.

https://drone.owncloud.com/owncloud/encryption/1088/43/16

--- Failed scenarios:

    /var/www/owncloud/testrunner/tests/acceptance/features/apiSharingNotifications/sharingNotifications.feature:23
    /var/www/owncloud/testrunner/tests/acceptance/features/apiSharingNotifications/sharingNotifications.feature:36
    /var/www/owncloud/testrunner/tests/acceptance/features/apiSharingNotifications/sharingNotifications.feature:70
    /var/www/owncloud/testrunner/tests/acceptance/features/apiSharingNotifications/sharingNotifications.feature:96
    /var/www/owncloud/testrunner/tests/acceptance/features/apiSharingNotifications/sharingNotifications.feature:135

9 scenarios (4 passed, 5 failed)
122 steps (105 passed, 5 failed, 12 skipped)

https://drone.owncloud.com/owncloud/encryption/1088/105/17

--- Failed scenarios:

    /var/www/owncloud/testrunner/tests/acceptance/features/webUISharingNotifications/shareWithUsers.feature:47

1 scenario (1 failed)
13 steps (8 passed, 1 failed, 4 skipped)

Those are master key encryption tests. The same scenarios fail with user key encryption also.

Now I understand what is the problem here. When I test against a GitHub branch, then the system-under-test is just a git clone of core. It does not automagically have any other apps available. In this case notifications app is not there.

When running against a release tarball, or daily-master tarball, those tarballs have various "bonus apps" code already bundled in the tarball.

I will adjust the drone starlark here so it fetches the notifications app code...

Works - great stuff!
PR owncloud/core#36546 loks good to go - owncloud/core#36546 (comment)