X Tutup
Skip to content

improve share expire description #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmattel merged 2 commits into from
May 18, 2022
Merged

improve share expire description #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35b9076
improve share expire description
NannaBarz May 18, 2022
b52d6ae
Update modules/classic_ui/pages/files/public_link_shares.adoc
mmattel May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/classic_ui/pages/files/public_link_shares.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,5 @@ Now that the share is created, you can:
| Allows users to create xref:files/webgui/sharing.adoc#creating-drop-folders[a drop folder], which can receive files from multiple recipients without revealing the contents of the folder.

| Password | Sets a password for protecting the link.
| Expiration | Sets an expiry date for the link. The public link expires at the end of the specified day.
| Expiration | Sets an expiry date for the link. The public link expires after the configured date as soon as the `OCA\Files_Sharing\ExpireSharesJob` job will run.
Copy link
Contributor

@phil-davis phil-davis May 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR owncloud/core#38775 fixed this behavior, released in ownCloud core 10.8.0.
The ExpireSharesJob now correctly only removes shares that have an expiration date of yesterday or before. Shares that expire on the current day are left in-place, because they need to work until the very end of the day.

|===
X Tutup