Merged
Conversation
Describes the point when a share with expiration definitely.
mmattel
reviewed
May 18, 2022
phil-davis
reviewed
May 19, 2022
|
|
||
| | Password | Sets a password for protecting the link. | ||
| | Expiration | Sets an expiry date for the link. The public link expires at the end of the specified day. | ||
| | Expiration | Sets an expiry date for the link. The public link expires after the configured date as soon as the `OCA\Files_Sharing\ExpireSharesJob` job will run. |
Contributor
There was a problem hiding this comment.
PR owncloud/core#38775 fixed this behavior, released in ownCloud core 10.8.0.
The ExpireSharesJob now correctly only removes shares that have an expiration date of yesterday or before. Shares that expire on the current day are left in-place, because they need to work until the very end of the day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describes the point when a share with expiration definitely.
https://github.com/owncloud/enterprise/issues/4454#issuecomment-800558840