X Tutup
Skip to content

add --destination-use-user-folder option to files:transfer-ownership command#3993

Merged
EParzefall merged 4 commits intomasterfrom
tr-own-destination-use-user-folder-opt
Sep 23, 2021
Merged

add --destination-use-user-folder option to files:transfer-ownership command#3993
EParzefall merged 4 commits intomasterfrom
tr-own-destination-use-user-folder-opt

Conversation

@mrow4a
Copy link
Contributor

@mrow4a mrow4a commented Sep 3, 2021

New option for occ files:transfer-ownership

Perform transfer of files and shares from /files/source-user-id to /files/dest-user-id

References: owncloud/core#39118

@mmattel
Copy link
Contributor

mmattel commented Sep 3, 2021

@mrow4a you need to add the new option also to the corresponding occ command set file

@mrow4a mrow4a force-pushed the tr-own-destination-use-user-folder-opt branch 2 times, most recently from a9bd095 to e4fcbaf Compare September 10, 2021 08:37
@mrow4a
Copy link
Contributor Author

mrow4a commented Sep 10, 2021

@mmattel done, but not sure if correctly

@phil-davis phil-davis self-requested a review September 12, 2021 10:35
@phil-davis phil-davis force-pushed the tr-own-destination-use-user-folder-opt branch from 248a490 to 1951342 Compare September 12, 2021 10:37
@phil-davis phil-davis requested a review from mmattel September 12, 2021 10:37
@phil-davis
Copy link
Contributor

Squashed and rebased.

@phil-davis
Copy link
Contributor

This is a new thing that will be in the next oC10.9 release. So no backport needed.

Comment on lines +271 to +274
--accept-skipped-shares` | always confirm to continue in case of skipped shares.
| `--destination-use-user-folder` | if destination user never logged in +
and thus has no mounts transfer +
directly to top-level user folder.
Copy link
Contributor

@mmattel mmattel Sep 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first line is a if
followed by a statemet - ok
but the next line does not point to a solution or explanation (directly to top-level user folder).
The sentence looks "strange/confusing" Please improve.

Well done, your changes render the following ✔️

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any suggestions how to improve? my docs were really engineer driven

Copy link
Contributor

@EParzefall EParzefall Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is difficult to parse. A comma after "mounts" should clarify things. Then the share is transferred directly to the top-level user folder. Is that what you meant? @mrow4a

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmattel @EParzefall adjusted, can you check now ?

@mmattel
Copy link
Contributor

mmattel commented Sep 23, 2021

@mrow4a thansk for the update.

Q: transfer directly to top-level user folder if destination user never logged in.

Does this mean the following:

If the target user never logged in, there is no skeleton on a directory level present for this user.
when using this option, it checks about this fact, creates the skeleton and moves the source directly in the root of the users home - correct?

What happens if this option is not set and the user never logged in?
Is there an error/warning message pointing to use that option?

@mrow4a
Copy link
Contributor Author

mrow4a commented Sep 23, 2021

@mmattel updated

@mmattel
Copy link
Contributor

mmattel commented Sep 23, 2021

@mrow4a thanks for updating - approved.

No backport needed, will go into 10.9

@EParzefall EParzefall merged commit 1d91742 into master Sep 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the tr-own-destination-use-user-folder-opt branch September 23, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup