X Tutup
Skip to content

Enhance external storage configuration#3048

Merged
AlexAndBear merged 5 commits intomasterfrom
external-storage-enhanchement
Jan 20, 2021
Merged

Enhance external storage configuration#3048
AlexAndBear merged 5 commits intomasterfrom
external-storage-enhanchement

Conversation

@AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Jan 20, 2021 •
edited
Loading

/admin_manual/configuration/files/external_storage_configuration_gui will be located at /admin_manual/configuration/files/external_storage/
Section Setting Up Google Drive and Dropbox Connections and FTP will be removed
Image for Enabling External Storage Support will be replaced
Added an important note for owncloud/core#38288

@AlexAndBear AlexAndBear requested a review from mmattel January 20, 2021 11:00
@AlexAndBear AlexAndBear linked an issue Jan 20, 2021 that may be closed by this pull request
Enhance external storage configuration #3047
Closed
12 tasks
@AlexAndBear AlexAndBear self-assigned this Jan 20, 2021
@AlexAndBear AlexAndBear requested a review from mmattel January 20, 2021 11:23
@AlexAndBear AlexAndBear requested a review from mmattel January 20, 2021 11:26
@mmattel
Copy link
Contributor

mmattel commented Jan 20, 2021 •
edited
Loading

I guess you have a typo in the headline...
maybe Enhache external --> Enhance external ? 😎

@AlexAndBear AlexAndBear force-pushed the external-storage-enhanchement branch from 823a2d7 to 0de2807 Compare January 20, 2021 11:33
@mmattel
Copy link
Contributor

mmattel commented Jan 20, 2021

Have you checked if the renamed file is referenced from somewhere via xref?
If that would be the case, we get broken links...

@AlexAndBear
Copy link
Author

AlexAndBear commented Jan 20, 2021 •
edited
Loading

Have you checked if the renamed file is referenced from somewhere via xref?
If that would be the case, we get broken links...

Nope, I was not aware of this, needs some adjustments here

@AlexAndBear AlexAndBear added the work in progress Still in development. Not to be merged. label Jan 20, 2021
@AlexAndBear AlexAndBear changed the title Enhache external storage configuration [WIP]Enhance external storage configuration Jan 20, 2021
@mmattel
Copy link
Contributor

mmattel commented Jan 20, 2021 •
edited
Loading

outch, your content is ok now,
but if you take a look on the files changed, it seems that another content from a recently merged PR has slipped in. Did you do a git pull --rebase on master and post checking out your branch a git pull --rebase origin master to sync the changes?

@mmattel
Copy link
Contributor

mmattel commented Jan 20, 2021

I was not aware of this

welcome to docs 😄

@AlexAndBear AlexAndBear force-pushed the external-storage-enhanchement branch from 0de2807 to ed6463f Compare January 20, 2021 11:53
@AlexAndBear AlexAndBear changed the title [WIP]Enhance external storage configuration Enhance external storage configuration Jan 20, 2021
@AlexAndBear AlexAndBear removed the work in progress Still in development. Not to be merged. label Jan 20, 2021
@AlexAndBear
Copy link
Author

AlexAndBear commented Jan 20, 2021 •
edited
Loading

@mmattel Here we go again ;)
Wondering why drone in docs-validate, did not report any errors 👎
$ antora --stacktrace generate --cache-dir cache --redirect-facility disabled --generator ./generator/xref-validator.js --clean site.yml --fetch
https://drone.owncloud.com/owncloud/docs/9162/1/4

mmattel
mmattel approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great - well done !
Is there backporting needed, and in case to which branches? (not below 10.5 as it makes imho less sense there)

@AlexAndBear AlexAndBear merged commit 9fc8133 into master Jan 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the external-storage-enhanchement branch January 20, 2021 13:33
@AlexAndBear
Copy link
Author

AlexAndBear commented Jan 20, 2021

@mmattel Thank you, long way ;)
I would love to see it in the current 10.6 docs

@mmattel
Copy link
Contributor

mmattel commented Jan 20, 2021

You may want to ask @mschreml to support doing the backport 😃

@AlexAndBear
Copy link
Author

AlexAndBear commented Jan 20, 2021 •
edited
Loading

OBEY
page alias has been removed, but should not!
#3052

@mschreml
Copy link
Contributor

mschreml commented Jan 20, 2021

@janackermann Can I do the backports for this and for #3052 ??

@AlexAndBear
Copy link
Author

AlexAndBear commented Jan 20, 2021

@mschreml would be very loveable!

mschreml pushed a commit that referenced this pull request Jan 20, 2021
[10.6] [PR 3048] ul
193abd4 
Backport of PR #3048
@mschreml mschreml mentioned this pull request Jan 20, 2021
Merged
mschreml pushed a commit that referenced this pull request Jan 20, 2021
[10.5] [PR 3048] ul
124bea9 
Backport of PR #3048
@mschreml mschreml mentioned this pull request Jan 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmattel mmattel mmattel approved these changes

Assignees

@AlexAndBear AlexAndBear

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhance external storage configuration

3 participants

@AlexAndBear @mmattel @mschreml
X Tutup