Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
force-pushed
the
deps/dbal-3
branch
4 times, most recently
from
4e4cb48 to
f3aa42a
Compare
DeepDiver1975
force-pushed
the
deps/dbal-3
branch
2 times, most recently
from
f307e61 to
a8fe522
Compare
DeepDiver1975
force-pushed
the
deps/dbal-3
branch
14 times, most recently
from
ff5305b to
4507585
Compare
jvillafanez
approved these changes
Feb 25, 2026
Member
jvillafanez
left a comment
jvillafanez
left a comment
There was a problem hiding this comment.
Some minor comments that can be tackled later.
I assume the double free() call doesn't cause problems. The rest are "translations" without any meaningful change, so they shouldn't cause problems neither.
| $data['value']=$row['value']; | ||
| $xml[] = $data; | ||
| } | ||
| while ($row = $result->fetchAssociative()) { |
Member
There was a problem hiding this comment.
I don't think this will cause problems, but the recommended way is to explicitly compare against false:
while (($row = $result->fetchAssociative()) !== false) {....}
Member
Author
There was a problem hiding this comment.
We have this in many places - valid as a follow up
DeepDiver1975
force-pushed
the
deps/dbal-3
branch
2 times, most recently
from
ac47d98 to
a077ad3
Compare
DeepDiver1975
force-pushed
the
deps/dbal-3
branch
from
a077ad3 to
6b40880
Compare
phil-davis
reviewed
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dbal 2.x is unmainted
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: