X Tutup
Skip to content

docs: add missing WND Kerberos settings to config.apps.sample#41104

Merged
mmattel merged 1 commit intomasterfrom
update_config_apps_sample
Nov 15, 2023
Merged

docs: add missing WND Kerberos settings to config.apps.sample#41104
mmattel merged 1 commit intomasterfrom
update_config_apps_sample

Conversation

@mmattel
Copy link
Contributor

@mmattel mmattel commented Nov 15, 2023

This PR does some changes to config.apps.sample:

  • adds missing WND Kerberos settings
  • adds missing WND keys other than Kerberos (yes, nobody took care...)
  • Sorts the WND keys for ease of finding
  • Some minor tweaks

make test-php-style ✔️

@jnweiger Note that this PR must go into 10.13.3 else we get some "challenges" with documenting the WND Kerberos stuff.

@update-docs
Copy link

update-docs bot commented Nov 15, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@mmattel
Copy link
Contributor Author

mmattel commented Nov 15, 2023

Failing test are unrelated:
Error response from daemon: No such image: owncloudci/drone-skip-pipeline:latest

Can someone help?

@mmattel mmattel requested a review from phil-davis November 15, 2023 16:13
@jvillafanez
Copy link
Member

I've restarted the build. Let's see if this time goes through.

@mmattel mmattel merged commit 5c08259 into master Nov 15, 2023
@delete-merged-branch delete-merged-branch bot deleted the update_config_apps_sample branch November 15, 2023 17:04
@jnweiger
Copy link
Contributor

Merged into release-10.13.3 branch.

jnweiger pushed a commit that referenced this pull request Nov 17, 2023
docs: add missing WND Kerberos settings to config.apps.sample
jnweiger added a commit that referenced this pull request Nov 17, 2023
* Merge pull request #41104 from owncloud/update_config_apps_sample

docs: add missing WND Kerberos settings to config.apps.sample

* Merge pull request #41106 from owncloud/wnd_fix_for_config_apps_sample

docs: clarify missing wnd config parameter

---------

Co-authored-by: Martin <github@diemattels.at>
phil-davis pushed a commit that referenced this pull request Nov 22, 2023
* Merge pull request #41104 from owncloud/update_config_apps_sample

docs: add missing WND Kerberos settings to config.apps.sample

* Merge pull request #41106 from owncloud/wnd_fix_for_config_apps_sample

docs: clarify missing wnd config parameter

---------

Co-authored-by: Martin <github@diemattels.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup