fix: proper error handling when deleting users/groups is failing#41077
Merged
DeepDiver1975 merged 1 commit intomasterfrom Nov 8, 2023
Merged
fix: proper error handling when deleting users/groups is failing#41077DeepDiver1975 merged 1 commit intomasterfrom
DeepDiver1975 merged 1 commit intomasterfrom
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
force-pushed
the
fix/js-dont-store-user-in-global-namespace
branch
from
eebc23c to
bda43ea
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Member
|
Found #41079 , but I don't think it's caused by this PR. We can fix it in a different PR. Other than that, the code looks fine to me. |
Member
Author
Reads like this needs to be fixed in some related but still untouched code segment. We can do a dedicated pr ... |
jvillafanez
approved these changes
Nov 8, 2023
delete-merged-branch
bot
deleted the
fix/js-dont-store-user-in-global-namespace
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In case of an error when deleting a user or a group no proper feedback was given to the user.
Bonus: fix undo on groups
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: