fix: create previews from first page on multi-page documents#41045
fix: create previews from first page on multi-page documents#41045phil-davis merged 4 commits intomasterfrom
Conversation
b39e053 to
21f2d28
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
@DeepDiver1975 this seems like a good thing - merge? |
|
this need some more testing - as per #41042 it is not working ...... no idea if the code has issues or there have been issues in applying the patch. |
|
Confirmed current code is not properly working. It seems this way previews are correctly generated from the first page of the document. |
|
works for me. This PR is quite old, so I will rebase to get up-to-date CI with current master. Then I will try to add an acceptance test - we already have thumbnail tests, so I should be able provide a multi-page PDF as a fixture along with the expected thumbnail of the first page. |
6b83926 to
bce605b
Compare
Hmm, this passed for me locally. I suppose there is some setting of the max preview size or something that needs to be done to get a "large" preview like in this test. |
Preview of PDFs is not enabled by default. I had to set it in system config |
|










Description
Previews are now generated from the first page and no longer from the last page.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: