fix: remove just uploaded files in case of error - also for storages …#40892
Merged
fix: remove just uploaded files in case of error - also for storages …#40892
Conversation
DeepDiver1975
force-pushed
the
fix/remove-failed-upload-file-2
branch
from
20da6a8 to
8d746ff
Compare
jvillafanez
reviewed
Jul 26, 2023
DeepDiver1975
force-pushed
the
fix/remove-failed-upload-file-2
branch
2 times, most recently
from
8390339 to
a080a2c
Compare
jvillafanez
approved these changes
Jul 26, 2023
pako81
reviewed
Jul 26, 2023
DeepDiver1975
force-pushed
the
fix/remove-failed-upload-file-2
branch
from
a080a2c to
6369bb9
Compare
phil-davis
approved these changes
Jul 26, 2023
pako81
approved these changes
Jul 26, 2023
Contributor
|
Confirmed. This fixes the broken files after timeout. |
|
merge it? |
Contributor
AFAIK it is fine to merge. Who decides to press the merge button these days? |
Member
Author
|
I would like to add some unit tests for this ..... but I can do this in a follow up pr as well .... |
Contributor
|
@DeepDiver1975 also needs a changelog entry. |
DeepDiver1975
force-pushed
the
fix/remove-failed-upload-file-2
branch
4 times, most recently
from
7f99193 to
3ced26a
Compare
…which do not support part files
DeepDiver1975
force-pushed
the
fix/remove-failed-upload-file-2
branch
from
3ced26a to
b8e8e58
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Member
Author
|
now squashed and with changelog |
phil-davis
approved these changes
Aug 3, 2023
Contributor
|
@pako81 this has been reviewed by multiple people and approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…which do not support part files
Description
Storage which does not support part files (external storage and s3) can leave broken files in the user space.
This change cleans up these broken files.
Alternative approach to #40891 - which is breaking apis too badly ...
Related Issue
How Has This Been Tested?
One has to force a failure during upload - e.g. adding one byte to the expected size at
core/apps/dav/lib/Connector/Sabre/File.php
Line 229 in 20da6a8
Screenshots (if appropriate):
Types of changes
Checklist: