Merged
Conversation
Member
|
Guest check should be the first thing to do. No need to get the "share_folder" config option for guests because we'll always return "/" for them regardless of the configuration. We probably should add some info in the "config.sample.php" file |
jvillafanez
reviewed
Jul 10, 2023
Author
|
Applied suggestions. |
added 2 commits
July 10, 2023 10:41
jvillafanez
approved these changes
Jul 10, 2023
Member
jvillafanez
left a comment
jvillafanez
left a comment
There was a problem hiding this comment.
Tiny change and we're done
Contributor
|
Just hooking myself in to see when merged to start a CTD run. |
|
Kudos, SonarCloud Quality Gate passed! |
9 tasks
Contributor
|
Works - I added a test scenario in guests PR owncloud/guests#595 |
shokri-navid
pushed a commit
to pondersource/core
that referenced
this pull request
Jul 16, 2023
* skip share_folder for guest users * add changelog * appy suggestions * update config.sample.php * fix return * just return root
|
Tested with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #40378 we've fixed the case of (not) moving the share target when the backend storage becomes temporary unavailable but we have now the collateral effect that guests do not see anymore their received shares as we are now forcing the creation of the target which will obviously fail for them as storage is read-only.
We now skip the
share_folderconfig.php option for guests and default to root.Related issue
https://github.com/owncloud/enterprise/issues/5842
How Has This Been Tested?
Types of changes
Checklist: