Remove sorting of users in js, rely on server side#40840
Merged
jvillafanez merged 3 commits intomasterfrom Aug 1, 2023
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
pako81
approved these changes
Jul 31, 2023
|
I guess we should try to get this in the 10.13 release given that owncloud/user_ldap#796 will be included in user_ldap 0.18.0 and that this app version will be bundled in core 10.13. So if we not merge this, anyone using 10.13 + user_ldap 0.18.0 will notice inconsistent behaviour between LDAP groups and all users sort order. |
|
@jvillafanez merge this or are tests still needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, users where sorted in the server alphabetically (by displayname it seems), and then the js code sort them again by username with a natural sort. This is weird because the next bunch of user might not be added at the bottom of the list as it's expected, and it might appear at the beginning of the list.
We'll rely on the server to sort the results, so the client will just need to append the results at the end of the list.
Related Issue
https://github.com/owncloud/enterprise/issues/5634
Motivation and Context
How Has This Been Tested?
Manually tested
Screenshots (if appropriate):
Types of changes
Checklist: