Update Google.php (cover variable initialisation not passing the else statement)#40822
Merged
phil-davis merged 3 commits intomasterfrom May 31, 2023
Merged
Update Google.php (cover variable initialisation not passing the else statement)#40822phil-davis merged 3 commits intomasterfrom
phil-davis merged 3 commits intomasterfrom
Conversation
Fixes: #40802 (Deleting a file in a Google Drive Mount throws an error) There can be the case that the varible is not defined when passing the else statement throwing an `undefined variable` error. This is now fixed as both variables are now initialized.
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
mmattel
changed the title
Contributor
|
@mmattel needs a changelog (or add the PR to some existing changelog related to the various Google Drive issues) |
|
Kudos, SonarCloud Quality Gate passed! |
phil-davis
approved these changes
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There can be the case that two varibles are not defined when not passing the else statement throwing an
undefined variableerror. This is now fixed as both variables are now initialized.Related Issue
Fixes: #40802 (Deleting a file in a Google Drive Mount throws an error)
Motivation and Context
No error should be thrown, code quality.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: