X Tutup
Skip to content

Exit with success when signing-key has been set#40794

Merged
phil-davis merged 2 commits intomasterfrom
CreateSignKey-exit-status
May 18, 2023
Merged

Exit with success when signing-key has been set#40794
phil-davis merged 2 commits intomasterfrom
CreateSignKey-exit-status

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented May 17, 2023

Description

See the changelog text:

The "occ security:sign-key:create" command exited with status 1 even when the
signing key was successfully created. This has been corrected. The command
now exits with status zero (0) when the command succeeded.

How Has This Been Tested?

Before:

$ php occ security:sign-key:create joan
$ echo $?
1

After:

$ php occ security:sign-key:create joan
$ echo $?
0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@owncloud owncloud deleted a comment from update-docs bot May 17, 2023
@phil-davis phil-davis marked this pull request as ready for review May 17, 2023 11:07
@phil-davis phil-davis self-assigned this May 17, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@phil-davis phil-davis merged commit 0f7bfd2 into master May 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the CreateSignKey-exit-status branch May 18, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup