X Tutup
Skip to content

Fix share into share move scenario #40612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pako81 merged 3 commits into from
Feb 22, 2023
Merged

Fix share into share move scenario #40612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
636565b
fix share into share move scenarios
Jan 31, 2023
b194ae1
fix style
Jan 31, 2023
6e43cf4
add changelog
Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/files_sharing/lib/Updater.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ private static function moveShareToShare($path) {

$shares = $shareManager->getSharesBy($userFolder->getOwner()->getUID(), \OCP\Share::SHARE_TYPE_USER, $src, false, -1);
$shares = \array_merge($shares, $shareManager->getSharesBy($userFolder->getOwner()->getUID(), \OCP\Share::SHARE_TYPE_GROUP, $src, false, -1));
$shares = \array_merge($shares, $shareManager->getSharesBy($userFolder->getOwner()->getUID(), \OCP\Share::SHARE_TYPE_LINK, $src, false, -1));

// If the path we move is not a share we don't care
if (empty($shares)) {
Expand Down
6 changes: 6 additions & 0 deletions changelog/unreleased/40612
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Fix share into share move scenario

Public links were lost upon moving share into another share as the share owner was not correctly set. This has been now partially fixed.

https://github.com/owncloud/core/pull/40612
https://github.com/owncloud/enterprise/issues/5565
X Tutup