X Tutup
Skip to content

fix: set length of oc_calendars.components to 255#40563

Merged
DeepDiver1975 merged 1 commit intomasterfrom
fix/calenars-components-length
Jan 5, 2023
Merged

fix: set length of oc_calendars.components to 255#40563
DeepDiver1975 merged 1 commit intomasterfrom
fix/calenars-components-length

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Jan 4, 2023

Description

Column is too small - see issue

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@DeepDiver1975 DeepDiver1975 force-pushed the fix/calenars-components-length branch from 7b597af to 3b8ace6 Compare January 4, 2023 23:27
@phil-davis
Copy link
Contributor

Looks good. @DeepDiver1975 changelog needed.

@DeepDiver1975 DeepDiver1975 force-pushed the fix/calenars-components-length branch from 3b8ace6 to 814b223 Compare January 5, 2023 09:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@owncloud owncloud deleted a comment from update-docs bot Jan 5, 2023
@owncloud owncloud deleted a comment from ownclouders Jan 5, 2023
@phil-davis
Copy link
Contributor

After checking out this branch and "upgrading" I have:

mysql> describe oc_calendars;
+---------------+-----------------+------+-----+---------+----------------+
| Field         | Type            | Null | Key | Default | Extra          |
+---------------+-----------------+------+-----+---------+----------------+
| id            | bigint unsigned | NO   | PRI | NULL    | auto_increment |
| principaluri  | varchar(255)    | YES  | MUL | NULL    |                |
| displayname   | varchar(255)    | YES  |     | NULL    |                |
| uri           | varchar(255)    | YES  |     | NULL    |                |
| synctoken     | int unsigned    | NO   |     | 1       |                |
| description   | varchar(255)    | YES  |     | NULL    |                |
| calendarorder | int unsigned    | NO   |     | 0       |                |
| calendarcolor | varchar(255)    | YES  |     | NULL    |                |
| timezone      | longtext        | YES  |     | NULL    |                |
| components    | varchar(255)    | YES  |     | NULL    |                |
| transparent   | smallint        | NO   |     | 0       |                |
+---------------+-----------------+------+-----+---------+----------------+
11 rows in set (0.00 sec)

components has correct new size of 255 - good.

@DeepDiver1975 DeepDiver1975 merged commit 27742a0 into master Jan 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/calenars-components-length branch January 5, 2023 13:01
@phil-davis phil-davis mentioned this pull request Jan 6, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a CalDAV-collection with VEVENT, VTODO and VJOURNAL from DAVx5 fails with SQL error

2 participants

X Tutup