Conversation
phil-davis
force-pushed
the
symfony-5.4
branch
3 times, most recently
from
bb1ab08 to
0104b0c
Compare
phil-davis
force-pushed
the
symfony-5.4
branch
from
0104b0c to
93bebcf
Compare
phil-davis
force-pushed
the
symfony-5.4
branch
from
c57d7ec to
3e77cd7
Compare
phil-davis
force-pushed
the
symfony-5.4
branch
from
3e77cd7 to
26c3e97
Compare
phil-davis
force-pushed
the
symfony-5.4
branch
3 times, most recently
from
fa8b5a1 to
dd03b18
Compare
|
Note: needs discussion about when we actually do this - now for 10.13, or later in the year. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
We should probably try to get this into 10.13.0. I don't think we will able to release an other major version before November 2023. |
Sounds reasonable. I don't think that there will be much work in adjusting app code - the few things that had to be changed in core are known, so I can look for those in apps easily. The main effort will "just" be going through the process of QA and release for new versions of quite a few apps (might be 10 or 15 to do). |
|
Merging - we will get nightly CI from all the apps overnight and can sort out which apps also need touching. |
2 participants
Description
Code and tests have already been updated so that they work with the existing Symfony 4.4 and also work with Symfony 5.4.
See the related issue for links to those PRs.
IMO this is ready for merge to core.
Note: if we merge this, then it will end up in the 10.13 release. We will have to also release any apps that need code changes. Those will be found by nightly CI running with core master having Symfony 5. Apps can have code made compatible with both Symfony 4 and 5, so any effected apps can be released separately prior to 10.13 and will still work with older 10.* releases that have Symfony 4.
There will be some effort needed to sort out and release the apps.
Related Issue
#39630
Motivation and Context
Symfony 4 support is heading to the end.
How Has This Been Tested?
CI
Types of changes
Checklist: