[full-ci] Show Username on personal profile settings page#40510
Merged
mmattel merged 4 commits intoowncloud:masterfrom Jan 31, 2023
Merged
[full-ci] Show Username on personal profile settings page#40510mmattel merged 4 commits intoowncloud:masterfrom
mmattel merged 4 commits intoowncloud:masterfrom
Conversation
T0mWz
changed the title
|
|
Contributor
|
@phil-davis can you kick CI ? |
phil-davis
changed the title
phil-davis
force-pushed
the
UsernameProfile
branch
from
0148a99 to
ed90cc3
Compare
Contributor
|
@tomwezepoel @T0mWz please click the buttons to "sign" the CLA. |
phil-davis
approved these changes
Jan 31, 2023
Contributor
|
@DeepDiver1975 @jvillafanez or anyone, please review. This seems to be a sensible thing to show on the Personal General Settings page. In the past, after changing my full name (display name) I have wondered what my actual username is, and couldn't see it displayed anywhere. |
phil-davis
force-pushed
the
UsernameProfile
branch
from
ae33636 to
af5bb04
Compare
|
Kudos, SonarCloud Quality Gate passed! |
DeepDiver1975
approved these changes
Jan 31, 2023
Member
DeepDiver1975
left a comment
DeepDiver1975
left a comment
There was a problem hiding this comment.
I see no issue in showing the username
jvillafanez
approved these changes
Jan 31, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When you make use of an external identity provider, for example Shibboleth or OIDC.
Your username within the environment may be different from the one you use to log in to the IdP.
When autocomplete is disabled for sharing and your full username have to be entered, then it's handy to know what's your username
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Todo: