Description

Empty directories were left inside the files_versions directory. For large installations this is a waste of space because there could be a lot of empty directories that aren't useful in any way.

Related Issue

https://github.com/owncloud/enterprise/issues/5471

Motivation and Context

How Has This Been Tested?

Mostly tested by deleting files from the web UI

1. Create "/f1/f2/f3" folder and upload a file with some versions
2. Check that the there are versions in <userdir>/files_versions/f1/f2/f3/
3. Remove the uploaded file

There should be only the <userdir>/files_versions folder without any directory in it. This is because the "f1/f2/f3" folders were empty.

Additional checks done:

• With multiple files, removing only one will keep the folder in the files_versions because there are more versions inside
• Removing the directory containing the files (removing "/f1/f2/f3" folder so "/f1/f2" is empty). Only <userdir>/files_versions exists because the rest of the folders were empty.
• Moving the files / directory around. As long as the source parent folder doesn't have versions, the folders will also be removed.
• occ versions:cleanup and occ versions:expire works with the same conditions.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

Note:
Existing empty version folder won't be removed unless a version ends up inside any of them. In this case, there won't be any difference and the folder will be removed once the last version is removed from the folder.