add shib auth support for redirect url#40470
Merged
DeepDiver1975 merged 5 commits intomasterfrom Dec 12, 2022
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Contributor
|
💥 Acceptance tests pipeline apiFederationToShares2-latest-mariadb10.2-php7.4 failed. The build has been cancelled. |
Contributor
|
💥 Acceptance tests pipeline apiShareOperationsToRoot1-mariadb10.2-php7.4 failed. The build has been cancelled. |
Contributor
|
💥 Acceptance tests pipeline apiShareManagementToRoot-mariadb10.2-php7.4 failed. The build has been cancelled. |
Contributor
|
💥 Acceptance tests pipeline apiShareManagementToShares-mariadb10.2-php7.4 failed. The build has been cancelled. |
mrow4a
force-pushed
the
e5450/redirect-url
branch
3 times, most recently
from
b901acc to
14d9ae3
Compare
mrow4a
force-pushed
the
e5450/redirect-url
branch
from
14d9ae3 to
2a1be72
Compare
mrow4a
force-pushed
the
e5450/redirect-url
branch
from
2a1be72 to
db97c85
Compare
DeepDiver1975
requested changes
Nov 28, 2022
DeepDiver1975
approved these changes
Dec 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Without this change, server-side Apache Auth (e.g. Shibboleth) resulted in redirect to default owncloud page, instead of last visited page. We now correctly handle redirect_url.
Related Issue
How Has This Been Tested?
Types of changes
Checklist: