allow specifying available space for objectstorages#40389
Merged
Conversation
Member
|
Maybe "availableStorageHint" makes more sense taking into account we aren't enforcing that limit. It seems more clear that the storage could have more or even less space available. You can also check https://github.com/owncloud/core/blob/master/lib/private/legacy/helper.php#L141 so the admin can use "1GB" instead of the actual number of bytes. Other than that, it looks good. |
DeepDiver1975
approved these changes
Sep 28, 2022
90f9431 to
909f125
Compare
mrow4a
added a commit
to owncloud/docs-server
that referenced
this pull request
Sep 28, 2022
52bd8b0 to
1a5c8a0
Compare
phil-davis
reviewed
Sep 29, 2022
Contributor
Author
|
@DeepDiver1975 needed to adjust the class so that I could add test coverage (due to static functions with Filesystem::X). if you could quickly revisit |
phil-davis
approved these changes
Sep 29, 2022
mmattel
added a commit
to owncloud/docs-server
that referenced
this pull request
Sep 29, 2022
mmattel
pushed a commit
to owncloud/docs-server
that referenced
this pull request
Sep 29, 2022
mmattel
pushed a commit
to owncloud/docs-server
that referenced
this pull request
Sep 29, 2022
Backport of PR #658
mmattel
pushed a commit
to owncloud/docs-server
that referenced
this pull request
Sep 29, 2022
mmattel
pushed a commit
to owncloud/docs-server
that referenced
this pull request
Sep 29, 2022
Backport of PR #658
mmattel
added a commit
to owncloud/docs-server
that referenced
this pull request
Sep 29, 2022
[10.11] [PR 658] doc update for owncloud/core#40389
mmattel
added a commit
to owncloud/docs-server
that referenced
this pull request
Sep 29, 2022
[10.10] [PR 658] doc update for owncloud/core#40389
DeepDiver1975
approved these changes
Sep 30, 2022
3e8b67c to
a974604
Compare
|
Kudos, SonarCloud Quality Gate passed! |
mmattel
added a commit
to owncloud/docs-server
that referenced
this pull request
Oct 4, 2022
mmattel
added a commit
to owncloud/docs-server
that referenced
this pull request
Oct 4, 2022
EParzefall
added a commit
to owncloud/docs-server
that referenced
this pull request
Oct 4, 2022
Revert "[10.11] [PR 658] doc update for owncloud/core#40389"
EParzefall
added a commit
to owncloud/docs-server
that referenced
this pull request
Oct 4, 2022
Revert "[10.10] [PR 658] doc update for owncloud/core#40389"
Contributor
|
Confirmed in 10.12.0-rc.2 with scality s3. |
This was referenced Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Feature: Allow specifying available space for objectstorages
Before this change, objectstorages were reporting only infinite storage space. This could have caused problems in other apps that rely on this storage method, e.g. metrics app that monitors available space
Related Issue
How Has This Been Tested?
Add configurations for files primary s3 being ceph, specifying
availableStorageStart ceph additionaly with owncloud instance
Types of changes
Checklist:
Example
Example use-case: metrics app
Now metric is correctly reported in the app
