Adjust installation database details#40348
Merged
phil-davis merged 1 commit intomasterfrom Nov 14, 2022
Merged
Conversation
phil-davis
force-pushed
the
issue-39871
branch
from
009c6bb to
608920b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
Any update? |
phil-davis
force-pushed
the
issue-39871
branch
from
608920b to
b7efd66
Compare
phil-davis
requested review from
AlexAndBear,
JammingBen,
jnweiger and
jvillafanez
Contributor
Author
I rebased and put this change out for review. @jnweiger #39871 (comment) |
Member
|
I guess parameterizing the example is too much taking into account we shouldn't change it too often and it won't solve the translation problem.... |
jvillafanez
approved these changes
Nov 14, 2022
Member
Isn't it smart enough to use the default port for PostgreSQL? I thought you need to provide the port if you aren't using the default one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the space from
localhost: 5432on the installation screen. Note: this changes a translated string, so it can't get into 10.11 - the change needs to go into master and wait a bit for all the language translations to be updated.TBD - improve PostgreSQL hint - this can be done in a next PR when we know what text to write.
Related Issue
#39871
How Has This Been Tested?
Types of changes
Checklist: