Fix case sensitivity for app passwords/tokens#40280
Closed
pako81 wants to merge 2 commits intoowncloud:masterfrom
pako81:fix-app-passwords-case-sensitive
Closed
Fix case sensitivity for app passwords/tokens#40280pako81 wants to merge 2 commits intoowncloud:masterfrom pako81:fix-app-passwords-case-sensitive
pako81 wants to merge 2 commits intoowncloud:masterfrom
pako81:fix-app-passwords-case-sensitive
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Kudos, SonarCloud Quality Gate passed! |
phil-davis
reviewed
Aug 10, 2022
| Summary | ||
| ------- | ||
|
|
||
| * Bugfix - Fix case sensitivity for app passwords/tokens - [#40280](https://github.com/owncloud/core/pull/40280) |
Contributor
There was a problem hiding this comment.
We don't directly edit this file. See PR #40281 for a suggested changelog entry. I also made a test scenario there.
Author
|
Closing this in favour of #40281 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Fix case sensitivity for app passwords/tokens
Related Issue
Motivation and Context
Currently, app passwords/tokens are case sensitive. That is, login will be prevented if the entered username has different case as the app password/token's username (which comes from the user's session).
How Has This Been Tested?
User1and create an app password/token --> username will be automatically set toUser1and saved as thelogin_namein theoc_authtokentable.user1as username (note the different casing):Before this fix --> login failed with exception https://github.com/owncloud/core/blob/master/lib/private/User/Session.php#L927
After this fix --> login is correctly allowed, which is consistent with the "normal" login via username/password where usernames are case-insensitive.
Types of changes
Checklist: